Skip to content

fix: secure terminal echo and package verification - #96

Merged
jsugg merged 2 commits into
mainfrom
fix/secure-terminal-echo
Oct 13, 2026
Merged

jsugg merged 2 commits into
mainfrom
fix/secure-terminal-echo

Conversation

@jsugg

@jsugg jsugg commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Changes

Reopen saved terminals without following links. Check the opened fd's type,
owner, permissions, and terminal status before writing. Keep echo nonblocking
and leave terminal settings alone.

Echo only the last 8 KiB of each stream, strip controls except newline and tab,
and cap the resulting UTF-8 text at 8 KiB too. Raw capture files and run outcomes
stay unchanged. Tests use owned PTYs and cover unsafe paths, permissions,
unavailable devices, Unicode, malformed bytes, and truncation.

Build extracted source-package tests in a fresh target directory. A shared
workspace target had reused an older test binary despite the new archive's
matching source. The scripts guide now warns against sharing that target.

Checks

  • Clean scripts/check.sh full: 545 tests, format/build/Clippy, actual Rust 1.85,
    rustdoc, dependency checks, Markdown, offline links, package policy, and publish
    dry run passed.
  • Fresh clean archive at 645e5a8, outside the workspace, using actual Rust 1.85
    and a fresh consumer target: 454 bin tests passed, including all eight terminal
    tests. Archive VCS metadata and extracted source match the candidate.
  • Exact corrected CI package block: 454 bin tests passed locally.
  • Workflow guards, actionlint, shellcheck for all scripts, the failure-injection
    harness, and scripts-guide lint passed.

All required and additional current-head checks must pass before merge.

No publication, tags, repository settings, or branch cleanup.

A shared workspace target can reuse an older bin test executable.
Build each extracted consumer in a fresh target directory.
@jsugg
jsugg merged commit 1766833 into main Oct 13, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant